ng-zorro-antd icon indicating copy to clipboard operation
ng-zorro-antd copied to clipboard

feat(module: table): add summary

Open ElderJames opened this issue 4 years ago • 7 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: close #5984

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

ElderJames avatar Feb 09 '21 08:02 ElderJames

This preview will be available after the AzureCI is passed.

zorro-bot[bot] avatar Feb 09 '21 08:02 zorro-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.51%. Comparing base (13e8a45) to head (8bcf045).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6418   +/-   ##
=======================================
  Coverage   91.50%   91.51%           
=======================================
  Files         534      535    +1     
  Lines       18408    18411    +3     
  Branches     2904     2904           
=======================================
+ Hits        16844    16848    +4     
+ Misses       1243     1242    -1     
  Partials      321      321           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 09 '21 08:02 codecov[bot]

Is there something preventing this PR to be merged?

bcherkezovtf avatar Mar 08 '24 14:03 bcherkezovtf

If there is something I can help with the merge of the PR?

bcherkezovtf avatar May 13 '24 07:05 bcherkezovtf

hi @bcherkezovtf, I'm not sure the author @ElderJames can be touched. I'm sorry for reviewing this pr so late.

If you are still willing to deal with this pr, you can rebase it to master and make sure NzTfootSummaryDirective support standalone well, then add sufficient tests and make them passed.

Of course, if you don't wanna do that, please give us feedback :)

This feature is quite necessary, and we are planning to merge it in the next minor version v18.1.

Laffery avatar Jun 30 '24 01:06 Laffery

Hello @Laffery , what should I do to fix the tests?

ElderJames avatar Jun 30 '24 01:06 ElderJames

Hello @Laffery , what should I do to fix the tests?

Hi @ElderJames, you should add a tfoot.spec.ts under the directory components/table/src/testing and write some unit tests for nzSummary. You can refer to other test files in that directory :)

Laffery avatar Jun 30 '24 03:06 Laffery

hi @bcherkezovtf, I'm not sure the author @ElderJames can be touched. I'm sorry for reviewing this pr so late.

If you are still willing to deal with this pr, you can rebase it to master and make sure NzTfootSummaryDirective support standalone well, then add sufficient tests and make them passed.

Of course, if you don't wanna do that, please give us feedback :)

This feature is quite necessary, and we are planning to merge it in the next minor version v18.1.

Hi @Laffery, for the moment I'm pretty occupied and I'm not sure if I'll have the time. It's great that you decided to continue with this feature.

bcherkezovtf avatar Jul 01 '24 07:07 bcherkezovtf

hi @ElderJames, how are you doing? We are planning to release v18.1 about in the coming week, is there any progress on this work?

Laffery avatar Jul 17 '24 07:07 Laffery

Sorry, I don't have time to finish the rest of stuff recently.

ElderJames avatar Jul 17 '24 08:07 ElderJames

Sorry, I don't have time to finish the rest of stuff recently.

That's OK, I'd like to work on the rest of stuff

Laffery avatar Jul 17 '24 23:07 Laffery

hi @ElderJames, everything had been done in #8639 , thanks for your contribution!

Laffery avatar Jul 18 '24 04:07 Laffery