TAB icon indicating copy to clipboard operation
TAB copied to clipboard

Big spacing on tab for player who used player#hidePlayer() to hide all online players on the list

Open TheJoshue opened this issue 2 years ago • 12 comments

Server version

Paper 1.12.2

TAB version

3.1.5

Describe the bug

When we use player#hidePlayer() in our/any plugin (most probably player hiding/visibility plugins for lobby/hub servers) we experience this: image

  • Just for sake of proofing what is going on, this is when players are not hidden: image

Expected behavior

We expect this: image

Steps to reproduce

  1. Get any plugin that uses mentioned (player#hidePlayer()) code in itself (or code it yourself) and put it onto server, load it correctly.
  2. Try to hide players for yourself while you have other player online whose tab name is longer than the player who is trying to use hide function
  3. This will happen.

Additional info

  • This does happen on any mc version (any mc server version with any mc client version)

Checklist

  • [X] I am running latest version of the plugin
  • [X] I have read the wiki to make sure it's not an issue with configuration
  • [X] I have read the Compatibility wiki page and am not trying to run the plugin on an unsupported server version / platform

TheJoshue avatar Oct 16 '22 17:10 TheJoshue

Give the player vanished metadata attribute and those who should see the player tab.seevanished permission.

NEZNAMY avatar Oct 16 '22 17:10 NEZNAMY

Also a notice: In most cases this happens when 1 player is op and it gets de-opped, then when you try to hide/unhide players this will happen This will not happen if you restart server and nobody ever had OP (except 1 player) and however many times any of (let's say there are 3 players online because i tested like that) 3 players online try to hide/unhide other players for them, this WILL NOT happen (i tested for like 15 minutes spamming a lot of things on all 3 clients, also all clients are on different mc version)

TheJoshue avatar Oct 16 '22 17:10 TheJoshue

i don't know if this would be worth opening another issue but image

This happened while all players were op, then i did some hide/unhide functions (multiple times idk how many per player) for all clients and then when i got into vanish (with 1 player).

TheJoshue avatar Oct 16 '22 17:10 TheJoshue

Sounds like the same kind of issue which I offered a solution for.

NEZNAMY avatar Oct 16 '22 17:10 NEZNAMY

Give the player vanished metadata attribute and those who should see the player tab.seevanished permission.

Are you saying to add this metadata attribute within the plugin i am coding?

TheJoshue avatar Oct 16 '22 17:10 TheJoshue

Yes, for TAB to properly detect the player as vanished.

NEZNAMY avatar Oct 16 '22 17:10 NEZNAMY

Yes, for TAB to properly detect the player as vanished.

ok, is this like LuckPerms thing? that metadata attribute

TheJoshue avatar Oct 16 '22 17:10 TheJoshue

Bukkit API.

NEZNAMY avatar Oct 16 '22 17:10 NEZNAMY

Ok thanks, i will try then go back here and reply when i test things out with what you said

TheJoshue avatar Oct 16 '22 17:10 TheJoshue

Ok thanks, i will try then go back here and reply when i test things out with what you said

Did you try?

Tanguygab avatar Oct 21 '22 20:10 Tanguygab

@TheJoshue

NEZNAMY avatar Oct 30 '22 11:10 NEZNAMY

Hi, i did not yet try, i was busy with some stuff i will try to test it out today more thoroughly Sorry for the wait

TheJoshue avatar Oct 30 '22 11:10 TheJoshue

@TheJoshue if you don't test it, I will close this as it's not an issue, but expected behavior (https://github.com/NEZNAMY/TAB/wiki/Additional-information#vanish-detection).

NEZNAMY avatar Nov 04 '22 12:11 NEZNAMY

Inactive user, assuming plugin works as described and user didn't follow instructions.

NEZNAMY avatar Nov 09 '22 21:11 NEZNAMY