[Unlimited nametag mode] Desync while flying

[SecretlyJealous]

Server version

1.20.4

TAB version

4.1.2

Describe the bug

We started using this plugin today to bypass the minecraft nametag limitations. Sometimes nametags will float very high or just be on the right side instead of the middle, generally it seems like nametags will just go away from the centre depending on movement. It seems similar to this issue: https://github.com/NEZNAMY/TAB/issues/1198 but because we have a lot of players with the ability to fly the issue is a lot more noticeable.

Unlimited nametag mode and scoreboard teams is the only thing we have enabled Config: https://pastebin.com/zZRMiHPc

scoreboard-teams:
  enabled: true 

unlimited-nametag-mode:
    enabled: true

Example of what happens:

Expected behavior

Nametag should always stay in the centre

Steps to reproduce

1. Not sure how to reliably cause this

Additional info

No response

Checklist

• [X] I am running latest version of the plugin
• [X] I have read the wiki to make sure it's not an issue with configuration
• [ ] I ticked all of the boxes without actually reading them
• [X] I have read the Compatibility wiki page and am not trying to run the plugin on an unsupported server version / platform
• [X] I am willing to cooperate to get this issue resolved faster, including providing any additional information requested or testing new builds

[Tanguygab]

Could this be the reason? https://github.com/NEZNAMY/TAB/wiki/Feature-guide:-Unlimited-nametag-mode#additional-note-3---position-desync

[SecretlyJealous]

Could this be the reason? https://github.com/NEZNAMY/TAB/wiki/Feature-guide:-Unlimited-nametag-mode#additional-note-3---position-desync

Has this bug been reported on the Minecraft bugs page?

[NEZNAMY]

We are not aware of that. Minecraft's issue tracker is one of the most confusing things ever. Search engine doesn't work properly, filtering doesn't work properly and there are over 8000 open bug reports, so it would likely not get fixed anyway.

[SecretlyJealous]

I asked someone for a possible solution on this and they replied with: "This can be fixed with a different implementation by listening to outgoing packets and trailing them with the mounting information instead of what TAB does currently"

Not sure if there are any issues with this solution but I thought I would let you know about it and see if you agree with that solution or if it comes with its own issues

[NEZNAMY]

[NEZNAMY]

I have pushed a commit that changes teleport packets into move packets. This will result in the error being copied and therefore not noticeable. It should also improve synchronization while moving. The issue can still be reproduced by sneaking, where plugin respawns the armor stands for instant position change instead of an animation. This could possibly be eliminated by not doing this for flying players. Are you interested in it?

[SecretlyJealous]

I have pushed a commit that changes teleport packets into move packets. This will result in the error being copied and therefore not noticeable. It should also improve synchronization while moving. The issue can still be reproduced by sneaking, where plugin respawns the armor stands for instant position change instead of an animation. This could possibly be eliminated by not doing this for flying players. Are you interested in it?

Yes! This would be useful, thank you

[NEZNAMY]

Done, although it looks a little strange that when sneaking down while flying your nametag doesn't go lower, but I cannot fix that anymore. Other than that, it is now perfectly synced to match the vanilla bug. I think we can call it here.