dailp-encoding icon indicating copy to clipboard operation
dailp-encoding copied to clipboard

MVP for user-contributed document audio

Open sammcvicker opened this issue 1 year ago • 3 comments

Opening this as a draft to share the code; not ready to merge.

  • feat(schema): add new mutations and input types
  • feat(graphql): implement new mutation resolvers
  • feat(db) added queries and implemented database_sql.rs functions.

TODO

  • [x] Couldn't get sqlx-types.json to build

sammcvicker avatar Nov 18 '24 20:11 sammcvicker

Deploy Preview for dailp failed.

Name Link
Latest commit 7838c87faaf04c75251a2187be40cef8232b82c5
Latest deploy log https://app.netlify.com/projects/dailp/deploys/68f7966a17dca70007d5e9a6

netlify[bot] avatar Dec 16 '24 22:12 netlify[bot]

@GracefulLemming update from today:

@sammcvicker and I paired ~2 1/2 hours to get recording audio into a MVP/working state. We found two sets of mocks on figma. The second set I had not reviewed and seemed to have some unanswered questions jotted in the mocks. We decided to focus on functionality and getting some good abstractions for upload/record between word and document oriented components. Aside from UX decisions, the last bits of functionality to add to the frontend are:

  • [ ] Editors' ability to curate (hide/show to readers) contributed audio
  • [ ] Contributor names and contributed on dates along side the audio player

On the first point, I don't quite see from the mocks any advice on this flow, so I think following in this MVP/functionality first spirit we will replicate the checkbox feeling from the word audio contribution UX.

On the second, we might consider if this valuable metadata and context should also be provided in other places the audio player is used, eg. word audio.

CharlieMcVicker avatar Dec 16 '24 22:12 CharlieMcVicker

@CharlieMcVicker @sammcvicker thank you for the updates! Here are some thoughts:

  1. I agree we should replicate what we do for word audio. Let's full send this.
  2. Also agree names will go on the base level audio component. To cue you in a little more: @nole2701 is currently working on implementing more info on user profiles. After that, we will be updating the audio component to include names.
  3. You're working on a fork so you don't have access to environment variables needed to pass CI. You should already have the credentials you need on you, just save them in the variables section on your fork. I'm happy to pass more info in other channels if needed.

GracefulLemming avatar Dec 23 '24 22:12 GracefulLemming