check_logstash icon indicating copy to clipboard operation
check_logstash copied to clipboard

events.out should be shown as average instead of total counts

Open MarcusCaepio opened this issue 6 years ago • 2 comments

Hi Thomas, I noticed that the perfdata for the .events.out are counted. I currently have a very huge events.out count (1,399,787,534.00 :D ) Wouldn't it be better to calculate the average like it's done with the inflight events?

Cheers, Marcus

MarcusCaepio avatar May 10 '19 14:05 MarcusCaepio

Hi,

I wanted a continous counter (like in https://www.monitoring-plugins.org/doc/guidelines.html#AEN201 ) . As far as my experience goes, this is better with graphers like Graphite or PNP4Nagios. Some tools can calculate averages and rate from counters but not the other way around.

Is that ok for you? Calculating and average in this case meant to store them in a temporary file or change the call of the check to give the last result. Which are both things that make the plugin less easy to handle.

The inflight events give the current rate, not an average. The calculation is done within Logstash not in the plugin.

Is that ok for you or do you need the average? The only way I can think of implementing it is in addition to the counter so your problem might not be solved.

widhalmt avatar May 21 '19 12:05 widhalmt

tbh, I don't see a benefit of a growing counter. The interesting part for me is the delta between the checks to see, if there are peaks between them without the need of doing magic in grafana. Also I don't know, if a neverending growing value has downsides in my InfluxDB.

MarcusCaepio avatar Jun 02 '22 07:06 MarcusCaepio

I agree with @widhalmt this adds quite some logic to the Plugin. Personally I think this would be more fitting for a either a metrics exporter or the Time series database should support calculating this.

martialblog avatar Dec 30 '22 17:12 martialblog