shifter icon indicating copy to clipboard operation
shifter copied to clipboard

Published 20 hours ago • verified publisher icon NERSC

munge.py: get error message from libmunge

Open maxim-belkin opened this issue 4 years ago • 5 comments

Obtain error messages from libmunge instead of hard-coding them.

maxim-belkin avatar Apr 03 '20 21:04 maxim-belkin

Perhaps, we could prefix error messages with "Munge error:"...

maxim-belkin avatar Apr 03 '20 21:04 maxim-belkin

@dmjacobsen, @scanon, please let me know if you have any comments or concerns regarding this PR

maxim-belkin avatar Apr 09 '20 00:04 maxim-belkin

It looks reasonable. I need to try it out. I think it will break our test since I mock munge in those.

scanon avatar Apr 09 '20 02:04 scanon

Coverage Status

Coverage increased (+0.009%) to 78.4% when pulling eb8713beb019b8f0faa0bc424358932ed401447f on maxim-belkin:munge-str-error into 4c97268698a7c14c3bc3b57d7da52c247a4f5923 on NERSC:master.

coveralls avatar Jun 03 '20 23:06 coveralls

We've been using Shifter with this patch on Blue Waters for a while now and didn't see any problems/issues related to this change.

maxim-belkin avatar Oct 19 '20 22:10 maxim-belkin