NCronJob icon indicating copy to clipboard operation
NCronJob copied to clipboard

[V5] Drop IJobNotificationHandler

Open nulltoken opened this issue 10 months ago • 1 comments

I'm not really seeing the value of this anymore.

Given that

  • IExceptionHandler already handles exceptions
  • Some minor improvements to IJobExecutionProgressReporter may allow a client to register to filtered events. This would require at least the following:
    • Make ExecutionProgress expose types and names of jobs
    • Enhance IJobExecutionProgressReporter an additional method which could look like `IDisposable Register(FuncExecutionProgress, bool> filterby, <Action<ExecutionProgress> callback);

Those two things altogether could replace the current value that IJobNotificationHandler serves today.

nulltoken avatar Feb 27 '25 20:02 nulltoken

Just to give some rational: IJobNotificationHandler was my first attempt for "outside observability" and to model job dependencies.

Over time, it might be totally redundant. So yeah, let's remove that bid.

linkdotnet avatar Feb 27 '25 20:02 linkdotnet