NCronJob icon indicating copy to clipboard operation
NCronJob copied to clipboard

[WIP] Adventures in the amazing world of specification of dependencies and predictiveness

Open nulltoken opened this issue 1 year ago • 3 comments

Pull request description

@linkdotnet Early work in the land of #108

Not a real PR as of now, rather a test bed for expectations (and tests that we'd like to see passing).

PR meta checklist

  • [ ] Pull request is targeted at main branch for code
  • [ ] Pull request is linked to all related issues, if any.

Code PR specific checklist

  • [ ] My code follows the code style of this project and AspNetCore coding guidelines.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly.
  • [ ] I have updated the appropriate sub section in the CHANGELOG.md.
  • [ ] I have added, updated or removed tests to according to my changes.
    • [ ] All tests passed.

nulltoken avatar Nov 06 '24 09:11 nulltoken

@linkdotnet Not all tests are passing.

Before going further with how the code should be changed to make them pass, I'd like some feedback from you about the following points:

  • Do the new added tests make sense?
  • What are new scenarios that we'd like to add?

Note: I haven't wandered in the region of dynamic jobs. Yet. Before diving into that, I'd like to ensure "how the lib should behave with 'simpler' jobs" is defined.

nulltoken avatar Nov 06 '24 09:11 nulltoken

I will have a look at this at the end of the week - unfortunately I am a bit swamped with stuff.

linkdotnet avatar Nov 06 '24 16:11 linkdotnet

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...CronJob/Configuration/Builder/DependencyBuilder.cs 41.66% 5 Missing and 2 partials :warning:
Files with missing lines Coverage Δ
src/NCronJob/Registry/JobRegistry.cs 96.15% <100.00%> (+0.27%) :arrow_up:
...CronJob/Configuration/Builder/DependencyBuilder.cs 65.00% <41.66%> (-35.00%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Nov 17 '24 21:11 codecov[bot]