metacatui icon indicating copy to clipboard operation
metacatui copied to clipboard

Profile and other URLs don't encode things they should encode

Open amoeba opened this issue 7 years ago • 1 comments

Dave V pointed out while discussing another topic that our profile page doesn't url encode the appropriate part of URLs like this:

https://search.dataone.org/#profile/http://orcid.org/0000-0002-0381-3766

which should be

https://search.dataone.org/#profile/http%3A%2F%2Forcid.org%2F0000-0002-0381-3766

in order to be spec-compliant.

Pros:

  • Spec complaint (yay specs)

Cons:

  • Uglier URLs

Any other pros/cons? PS: There are numerous places we'll need to fix this, not just the profile page. (If we fix this)

amoeba avatar Mar 07 '18 23:03 amoeba