geocat-comp icon indicating copy to clipboard operation
geocat-comp copied to clipboard

Trigger a subset of tests

Open cyschneck opened this issue 2 years ago • 1 comments

PR Summary

Closes #512

PR Checklist

General

  • [x] Make an issue if one doesn't already exist
  • [x] Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • [ ] Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • [x] Add appropriate labels to this PR
  • [x] Make your changes in a forked repository rather than directly in this repo
  • [x] Open this PR as a draft if it is not ready for review
  • [ ] Convert this PR from a draft to a full PR before requesting reviewers
  • [x] Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • [ ] If needed, squash and merge PR commits into a single commit to clean up commit history

cyschneck avatar Nov 09 '23 18:11 cyschneck

Looks like there is a bug in Github Action when using paths-ignore in pull_request (https://github.com/actions/runner/issues/2324). paths-ignore will work when: 1.) creating a new PR and 2.) pushing a change that only impacts the files included in paths-ignore. However, when a commit is added to the PR outside of the paths-ignore list, then the workflow will ignore all files in paths-ignore for all future commits

I will convert the paths-ignore files into verify-changed-files with some conditional statements on jobs running within a workflow. Instead of fully ignoring the file, the workflow should skip jobs when only specific files/folders are edited

cyschneck avatar Nov 09 '23 21:11 cyschneck