esmlab icon indicating copy to clipboard operation
esmlab copied to clipboard

significance tests

Open matt-long opened this issue 6 years ago • 3 comments

For our statistics functions, like weighted_cor it would be nice to enable computing significance metrics (p-value...).

@bradyrx, perhaps you can help with this?

matt-long avatar Mar 09 '19 13:03 matt-long

@matt-long, yes I'd be happy to open a PR on this. Are you trying to keep esmlab slim on dependencies?

xskillscore has a pearson_r_p_value function that is based in numpy and written as an xarray ufunc. Although this only allows a two-tailed test.

I can also port over some functions from climpred (https://github.com/bradyrx/climpred/blob/master/climpred/stats.py) which accounts for autocorrelation in the time series by computing the effective sample size (Bretherton et al. 1999).

bradyrx avatar Mar 09 '19 23:03 bradyrx

I am fine with dependencies as long as they are good ones.

matt-long avatar Mar 11 '19 20:03 matt-long

Implemented in https://github.com/NCAR/esmlab/pull/90, although should stay open until effective sample size is incorporated (will get on this when time allows).

bradyrx avatar Mar 28 '19 18:03 bradyrx