ccpp-framework icon indicating copy to clipboard operation
ccpp-framework copied to clipboard

Post capgen unification: pylint code

Open climbfuji opened this issue 11 months ago • 3 comments

Description

As of 2024-03-08:

> cd test
> ./pylint_test.sh
...
------------------------------------------------------------------
Your code has been rated at 8.48/10 (previous run: 8.48/10, +0.00)

This is likely going to change while we transition from prebuild to capgen and add, remove, modify features.

Solution

Fix coding style after capgen unification

Alternatives (optional)

Leave as is - not a good idea

Related to (optional)

n/a

climbfuji avatar Mar 08 '24 15:03 climbfuji

It would be great too to make a Github Action that automatically runs pylint against the relevant files and fails if the score is below some threshold. Although if there is interest then it should probably be done after pylint_test.sh produces good scores, or else the test will constantly fail.

nusbaume avatar Mar 11 '24 21:03 nusbaume

Also, we don't have to use pylint. There are other utilities like pycodestyle and black.

climbfuji avatar Mar 11 '24 21:03 climbfuji

@nusbaume Rather than have a specific threshold I wonder if it would be possible to just not allow the pylint score to decrease? That way we're either doing no harm, or improving things.

mkavulich avatar Mar 18 '24 20:03 mkavulich