ccpp-framework icon indicating copy to clipboard operation
ccpp-framework copied to clipboard

Fortran/metadata comparison incorrectly reporting bug when comparing Fortran variable declarations and metadata for derived types

Open climbfuji opened this issue 5 years ago • 2 comments

The Fortran/metadata comparison seems to incorrectly report a bug (this is the version used by @JulieSchramm) when comparing Fortran variable declarations and metadata for derived types:

kind mismatch ( != cmpfsw_type) in rrtmg_sw_post_run, at /Users/dom.heinzeller/scratch/ufs-weather-model/fortran_parser_julie/ccpp-physics-fork/physics/rrtmg_sw_post.meta:244
kind mismatch ( != sfcfsw_type) in rrtmg_sw_post_run, at /Users/dom.heinzeller/scratch/ufs-weather-model/fortran_parser_julie/ccpp-physics-fork/physics/rrtmg_sw_post.meta:252
kind mismatch ( != topfsw_type) in rrtmg_sw_post_run, at /Users/dom.heinzeller/scratch/ufs-weather-model/fortran_parser_julie/ccpp-physics-fork/physics/rrtmg_sw_post.meta:260
3 errors found comparing /Users/dom.heinzeller/scratch/ufs-weather-model/fortran_parser_julie/ccpp-physics-fork/physics/rrtmg_sw_post.meta to /Users/dom.heinzeller/scratch/ufs-weather-model/fortran_parser_julie/ccpp-physics-fork/physics/rrtmg_sw_post.F90

The metadata for the first variable:

[scmpsw]
  standard_name = components_of_surface_downward_shortwave_fluxes
  long_name = derived type for special components of surface downward shortwave fluxes
  units = W m-2
  dimensions = (horizontal_loop_extent)
  type = cmpfsw_type
  intent = inout
  optional = F

The Fortran declaration:

      type(cmpfsw_type), dimension(:),     intent(inout) :: scmpsw

climbfuji avatar Apr 07 '21 16:04 climbfuji

@dustinswales Do you still see this with capgen in SCM? Are there any additional changes needed for the framework? If not, then this should be closed as fixed. Thanks.

climbfuji avatar Aug 18 '25 15:08 climbfuji

@climbfuji I'm pivoting back to Capgen in the SCM this week and will look into this. Stay tuned.

dustinswales avatar Aug 20 '25 17:08 dustinswales