Remove offset on GOES obs converter

[braczka]

Description:

I removed the satellite channel offset within GOES ABI observation converter such that the wavelength in the obs_seq.out match that within the RTTOV coefficient file.

I also improved the documentation both within the GOES obs converter and the RTTOV module to alert the user to potential mismatch issues.

Fixes issue

#731

Types of changes

• [X] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [X] Documentation update

Documentation changes needed?

• [ ] My change requires a change to the documentation.
  • [X] I have updated the documentation accordingly.

Tests

I have performed offline checks with the GOES obs converter, then used those obs_seq.out files to run filter to confirm functionality.

Checklist for merging

• [ ] Updated changelog entry
• [X] Documentation updated
• [ ] Update conf.py

Checklist for release

• [ ] Merge into main
• [ ] Create release from the main branch with appropriate tag
• [ ] Delete feature-branch

Testing Datasets

• [ ] Dataset needed for testing available upon request
• [ ] Dataset download instructions included
• [X] No dataset needed

[hkershaw-brown]

Hi Brett, can you provide 2 GOES ABI observation files for testing since we also have this issue outstanding: https://github.com/NCAR/DART/issues/579 Thanks!

[braczka]

My work directory for testing the GOES obs converter (convert_goes_ABI_L1b) is located here: /glade/work/bmraczka/DART/observations/obs_converters/GOES/work/

An example of a GOES radiance raw data file is located there : OR_ABI-L1b-RadF-M6C08_G16_s20211841720210_e20211841729518_c20211841729575.nc. I can download another if needed.

FYI -- my folder for testing the RTTOV channel offset bug is here: /glade/work/bmraczka/DART/models/wrf/Akeem_bug/

[hkershaw-brown]

two would be great since the other bug is "bug: GOES converter does not handle multiple input files" Cheers, Helen

[braczka]

two would be great since the other bug is "bug: GOES converter does not handle multiple input files" Cheers, Helen

Done

[hkershaw-brown]

If you build the converter with rttov13, then run, it errors out on the namelist. I think this all the rrtov12 options in the input.nml &obs_def_rttov_nm

hkershaw@dec2158:/glade/derecho/scratch/hkershaw/DART/pull_reqeuests/pull_732/observations/obs_converters/GOES/work(GOES_obs_converter)$ ./convert_goes_ABI_L1b 
 
 --------------------------------------
 Starting ... at YYYY MM DD HH MM SS = 
                 2024  9 11  9 57 16
 Program convert_goes_ABI_L1b
 --------------------------------------
 
  set_nml_output Echo NML values to log file only
  goes_load_abi_map  Now loading L1C data from file OR_ABI-L1b-RadF-M6C08_G16_s2
 0211841720210_e20211841729518_c20211841729575.nc
 ERROR FROM:
  source : utilities_mod.f90
  routine: check_namelist_read
  message:  INVALID NAMELIST ENTRY:    cfrac_data             = .true. in nameli
 st obs_def_rttov_nml

[braczka]

Sorry -- the input.nml file got reverted to the default. The input.nml I used for the GOES conversion is here: /glade/work/bmraczka/DART/observations/obs_converters/GOES/work/input.nml.GOES_converter

[braczka]

see default input.nml comment

Changes made to make input.nml compatible to run the converter. Should be ready for approval.

[hkershaw-brown]

see default input.nml comment

Changes made to make input.nml compatible to run the converter. Should be ready for approval.

ok I haven't actually looked at this pull request since trying to run it. I'll update to main and take a look.