DART icon indicating copy to clipboard operation
DART copied to clipboard

model_mod templates input.nml

Open hkershaw-brown opened this issue 2 years ago • 3 comments

Quick note of an issue.

Robin hit this today, the input.nml defaults for a 3d sphere model don't have good defaults.

  • single_file_in/out true.

https://github.com/NCAR/DART/blob/502af7865e258530cba7c7daff6aed4390cbb649/models/template/work/threed_input.nml#L30-L31

  • In the &model_mod_check section of input.nml , the default value of qty_of_interest is QTY_STATE_VARIABLE. This is not appropriate for most models.

hkershaw-brown avatar Jun 20 '23 17:06 hkershaw-brown

&filter_nml has init_time_days = 0 and init_time_seconds = 0 as its defaults, and whenever those fields are nonnegative, DART uses them to override the time provided by the restart.

-1 -1 is a better default for 3d models.

hkershaw-brown avatar Jun 27 '23 17:06 hkershaw-brown

Need &obs_diag_nml appropriate for model.

currently have 1d obs_diag options for threed sphere input.nml

hkershaw-brown avatar Jul 17 '23 17:07 hkershaw-brown

templates have register_module https://github.com/NCAR/DART/blob/c8ddfac035a39bbb24451ced3b0aa5410ac62494/models/template/threed_model_mod.f90#L95-L96

this was 'removed' (half removed) in ~2021 https://github.com/NCAR/DART/blob/c8ddfac035a39bbb24451ced3b0aa5410ac62494/CHANGELOG.rst?plain=1#L772-L773

hkershaw-brown avatar Jul 15 '24 17:07 hkershaw-brown