DART icon indicating copy to clipboard operation
DART copied to clipboard

contamination of types_mod with other module data

Open hkershaw-brown opened this issue 2 years ago • 0 comments

Note for refactoring:

Data from other modules has crept into types_mod. I can't really justify the footprint of correcting this for its own sake, but this note is to keep track of this issue for any future refactoring.

State structure and filenames_io(?) https://github.com/NCAR/DART/blob/16595cad595b6349605c9bc8e021c7ecc2c2391a/assimilation_code/modules/utilities/types_mod.f90#L22

These parameters should also go home to their respective modules: https://github.com/NCAR/DART/blob/16595cad595b6349605c9bc8e021c7ecc2c2391a/assimilation_code/modules/utilities/types_mod.f90#L24-L33

Also a bunch of physical constants, probably should be in a physical_constants_mod and/or model specific: https://github.com/NCAR/DART/blob/16595cad595b6349605c9bc8e021c7ecc2c2391a/assimilation_code/modules/utilities/types_mod.f90#L100-L103

https://github.com/NCAR/DART/blob/16595cad595b6349605c9bc8e021c7ecc2c2391a/assimilation_code/modules/utilities/types_mod.f90#L117-L126

hkershaw-brown avatar Jan 31 '23 19:01 hkershaw-brown