DART
DART copied to clipboard
Feature request: routine to read a table of state variables from namelist
Use case
reading a table of state variables from a namelist, there are several of these in various model_mods (not including Lanai only models):
parse_variable_table verify_variables verify_variables vertify_variables verify_state_variables verify_state_variables verify_state_variables verify_state_variables fill_dart_kinds_table
Every time a new model is added to DART, we get a variation on one of these routines.
Is your feature request related to a problem?
Code repetition and all the associated problems that come with that.
vtablenamelength
is in types_mod. This is one of several non-types in types_mod
https://github.com/NCAR/DART/blob/16595cad595b6349605c9bc8e021c7ecc2c2391a/assimilation_code/modules/utilities/types_mod.f90#L24-L26
Describe your preferred solution
Generalize the routine: netcdf variable name, dart qty, update
Describe any alternatives you have considered
Define the state outside the model_mod
https://github.com/Benjamin-Gunn/DART/tree/state-variable-namelist
Skeleton program moved to my fork: https://github.com/hkershaw-brown/DART/tree/state-variable-namelist