bug: make_fake_obs array mismatch

[hkershaw-brown]

:bug: Your bug may already be reported! Please search on the issue tracker before creating a new issue.

Describe the bug

1. List the steps someone needs to take to reproduce the bug.
   cd DART/observations/obs_converters/utilities/threed_sphere (edit: now DART/observations/obs_converters/test_obs/) use mkmf.template with debugging ./quickbuild.csh (with debugging options in mkmf.template ./make_fake_obs

2. What was the expected outcome? make_fake_obs runs to completion

3. What actually happened?
   Array mismatch

Error Message

gfortran

At line 2396 of file ../../../../assimilation_code/modules/observations/obs_sequence_mod.f90
Fortran runtime error: Array bound mismatch for dimension 1 of array 'obs' (26/1)

intel

forrtl: severe (408): fort: (33): Shape mismatch: The extent of dimension 1 of array OBS is 26 and the corresponding extent of array VALUES is 1

Image              PC                Routine            Line        Source             
libnetcdff.7.dyli  000000011002A9D0  Unknown               Unknown  Unknown
make_fake_obs      000000010F54B2F3  _obs_sequence_mod        2396  obs_sequence_mod.f90
make_fake_obs      000000010F593E40  _obs_utilities_mo         222  obs_utilities_mod.f90
make_fake_obs      000000010F5938C1  _obs_utilities_mo         135  obs_utilities_mod.f90
make_fake_obs      000000010F6792AA  _make_fake_obs_IP         293  make_fake_obs.f90
make_fake_obs      000000010F6786C8  _MAIN__                   203  make_fake_obs.f90
make_fake_obs      000000010F4A005E  Unknown               Unknown  Unknown

Which model(s) are you working with?

none

Version of DART

v9.10.3

Have you modified the DART code?

No

Build information

Please describe:

1. mac laptop
2. ifort 19.1.3.301 and gfortran (MacPorts gcc9 9.3.0_3)

[hkershaw-brown]

branch make_fake_fix has a fix for this bug. Needs checking against other uses of create_obs.

[hkershaw-brown]

note check obs_sequence radar crash with debugging flags. May be related to this.

[hkershaw-brown]

make_fake_obs also needs:

• quickbuild.sh
• moving to programs or maybe more sensibly developer_tests. The comment in the code seems to suggest that make_fake_obs is for testing obs_diag:

! Generate an observation sequence FINAL file to thoroughly test obs_diag.
!
! Lots of goals for this routine.
! * all observation 'levels' for all 'VERTISxxxx' possibilities
! * exercise all 'regions'
! * exercise U,V wind combinations
!
! I want to test the vertical binning, the geographic binning, etc.