CUPiD icon indicating copy to clipboard operation
CUPiD copied to clipboard

Add rof back in to config.yml and add to jupyterbook section

Open TeaganKing opened this issue 10 months ago • 3 comments

The rof notebooks had been failing and causing general CUPiD failures. This PR brings the rof notebooks back in and also adds them as a juptyerbook section.

I tested the rof notebooks again and everything worked. Maybe the previous error was something in my environment? In any case, I added the rof component back in.

Note that there are still some StreamClosedErrors (output is below, and these errors may be concerning for users) but the notebooks themselves seem to run fine: /glade/work/tking/cupid_project/CUPiD/examples/key_metrics/output.txt

All PRs Checklist:

TeaganKing avatar Mar 05 '25 21:03 TeaganKing

The ERROR 1 message from https://github.com/NCAR/CUPiD/pull/197#pullrequestreview-2696530913 appears to be coming from the from scripts.utility import load_yaml statement, and I traced it further to the from pyogrio import read_dataframe line:

import error

Though I can't get it to show up in a command line:

(cupid-analysis) $ python
Python 3.11.4 | packaged by conda-forge | (main, Jun 10 2023, 18:08:17) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pyogrio import read_dataframe
>>>

mnlevy1981 avatar Mar 19 '25 00:03 mnlevy1981

Hi Mike, I re-installed cupid-analysis yesterday (3/19/2025). cupid-analysis env still have both pyogrio and geopandas. I was able to run cupid-diagnostics -rof under examples/key_metrics. The error you are getting looks familiar. I re-did ipykernel installation.

nmizukami avatar Mar 20 '25 12:03 nmizukami

Hi @nmizukami , Following up on our hallway conversation, @mnlevy1981 said he would take a look at this and your changes that addressed his comments above.

TeaganKing avatar May 07 '25 21:05 TeaganKing