Add rof back in to config.yml and add to jupyterbook section
The rof notebooks had been failing and causing general CUPiD failures. This PR brings the rof notebooks back in and also adds them as a juptyerbook section.
I tested the rof notebooks again and everything worked. Maybe the previous error was something in my environment? In any case, I added the rof component back in.
Note that there are still some StreamClosedErrors (output is below, and these errors may be concerning for users) but the notebooks themselves seem to run fine: /glade/work/tking/cupid_project/CUPiD/examples/key_metrics/output.txt
All PRs Checklist:
- [x] Have you followed the guidelines in our Contributor's Guide?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [x] Have you made sure that the
pre-commitchecks passed (#8 in Adding Notebooks Guide)? - [x] Have you successfully tested your changes locally?
The ERROR 1 message from https://github.com/NCAR/CUPiD/pull/197#pullrequestreview-2696530913 appears to be coming from the from scripts.utility import load_yaml statement, and I traced it further to the from pyogrio import read_dataframe line:
Though I can't get it to show up in a command line:
(cupid-analysis) $ python
Python 3.11.4 | packaged by conda-forge | (main, Jun 10 2023, 18:08:17) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pyogrio import read_dataframe
>>>
Hi Mike, I re-installed cupid-analysis yesterday (3/19/2025). cupid-analysis env still have both pyogrio and geopandas. I was able to run cupid-diagnostics -rof under examples/key_metrics. The error you are getting looks familiar. I re-did ipykernel installation.
Hi @nmizukami , Following up on our hallway conversation, @mnlevy1981 said he would take a look at this and your changes that addressed his comments above.