gource-action icon indicating copy to clipboard operation
gource-action copied to clipboard

File Filter still not working

Open ManuelRauber opened this issue 2 years ago • 5 comments

Hi @NBprojekt

Some time ago I've sent you a PR #15 because the check was not correct to see if a file filter is set or not.

However, it's still not working.

I've a running action here with gource-action: https://github.com/BoundfoxStudios/community-project/blob/develop/.github/workflows/repository-visualization.yml

As you can see in the debug log, the filter it recognized: https://github.com/BoundfoxStudios/community-project/actions/runs/4288063582/jobs/7469624333#step:4:53

image

Unfortunately, the .meta files are still visible in the output video.

I've also tried different syntaxes in the yaml file for setting the filter:

gource_file_filter: \.meta$
gource_file_filter: '\.meta$'
gource_file_filter: meta$

If I run gource locally with: gource --file-filter "\.meta$" --key --seconds-per-day 0.5 --auto-skip-seconds 0.1 I don't see the .meta files in the output.

Any idea what can be wrong?

ManuelRauber avatar Feb 28 '23 15:02 ManuelRauber

https://github.com/utensils/Envisaged/issues/14 ok, it may be that the version from the base image is simply too old for that filter.

ManuelRauber avatar Feb 28 '23 15:02 ManuelRauber

@NBprojekt would be really nice if you could update gource somehow. The base image itself is now 3 years old (see https://hub.docker.com/r/utensils/opengl).

Note to self: According to https://github.com/acaudwell/Gource#requirements "Gource's display is rendered using OpenGL and requires a 3D accelerated video card to run.".

Google only found https://hub.docker.com/r/nvidia/opengl as the only maintained image. Unfortunately (for this project), only Ubuntu and CentOS are available. No alpine.

koppor avatar Jul 02 '23 23:07 koppor

@NBprojekt would be really nice if you could update gource somehow. The base image itself is now 3 years old (see https://hub.docker.com/r/utensils/opengl).

Note to self: According to https://github.com/acaudwell/Gource#requirements "Gource's display is rendered using OpenGL and requires a 3D accelerated video card to run.".

Google only found https://hub.docker.com/r/nvidia/opengl as the only maintained image. Unfortunately (for this project), only Ubuntu and CentOS are available. No alpine.

@koppor If you want to use the latest one, check out https://github.com/BoundfoxStudios/action-gource

I've updated all the base images required to use the latest gource version.

ManuelRauber avatar Jul 03 '23 06:07 ManuelRauber

For the googlers: A more recent opengl docker image is https://github.com/boundfoxstudios/docker-opengl

@ManuelRauber Thank you for the reply and your work. I am trying it out now (https://github.com/JabRef/jabref/pull/10056).

koppor avatar Jul 03 '23 07:07 koppor

@ManuelRauber Sorry for my inactivity lately.

Will update the image and check if the filter work then properly.

NBprojekt avatar Sep 04 '23 08:09 NBprojekt