WorldWindAndroid icon indicating copy to clipboard operation
WorldWindAndroid copied to clipboard

Added fling listener to globe activity

Open mrdjohnson opened this issue 7 years ago • 0 comments

References #20

Please ignore the MultiGlobeActivity.java, that was added to this PR by accident and have not figured out how to remove it yet.

I did not want to get too deep into this and have to revert 90%.

I added a fling recognizer, it works but acts a little strange when the globe is fully zoomed out.

Wanted to get honest feedback on what I have so far. and ideas on what to do next / what else needs to be done for this PR.

There are a lot of "this." in the code where they do not seem to be needed. I am not sure how android handles it but in Java it is pretty off putting to see without reason because it indicates two variables with the same name. Wanted to see if it was ok if I got rid of those in the classes I am touching.

The GestureRecognizer classes has a list for listeners, but there is only one listener that is ever present. Was this for future proofing or can this be transformed to a GestureListener variable instead?

Should my pull requests be for master or develop?

Thank you for your time!

mrdjohnson avatar Jan 29 '17 04:01 mrdjohnson