validate icon indicating copy to clipboard operation
validate copied to clipboard

-R --rule defaults possibly not working as intended

Open ztaylor54 opened this issue 3 years ago • 2 comments

🐛 Describe the bug

I've been poking around at the codebase, and I've noticed some potentially undesirable behavior. According to the docs:

If the -R flag is not specified on the command-line, the default behavior is to use the pds4.label rule for target file inputs and to use the pds4.folder rule for target directory inputs.

And yet, if I print out the ValidationRule used when -R is not provided, I see:

PDS4 Label Skip Content

And, with -R pds4.label specified:

PDS4 Label

📜 To Reproduce

Steps to reproduce the behavior: Add a print of rule.getCaption() after this line, then run with the following options:

validate <some product label>
validate -R pds4.label <some product label>

🕵️ Expected behavior

Validate should behave according to the documentation, which would mean using the PDS4 Label ValidationRule for each run. I am concerned that Validate is skipping content validation by default.

📚 Version of Software Used

Current code base - here's the commit if you want to check it out.

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

:unicorn: Applicable requirements**

ztaylor54 avatar Jun 03 '21 23:06 ztaylor54