aerie icon indicating copy to clipboard operation
aerie copied to clipboard

AMPCS dictionary parsing relies on parsing newlines from XML

Open cartermak opened this issue 4 months ago • 0 comments

Checked for duplicates

No - I haven't checked

Is this a regression?

No - This is a new bug

Version

3.5.0

Describe the bug

The logic to parse the dictionary type from the header of an AMPCS XML dictionary relies on splitting on newline characters, making it possibly sensitive to:

  • File formatting (e.g., having the header on the same line as the <command_dictionary>
  • Using Windows CRLF line endings

https://github.com/NASA-AMMOS/aerie/blob/9faa95c2846b9d1a75760c859571f94b001decbd/sequencing-server/plugins/ampcs-dictionary-parser/src/ampcs-parser.ts#L19-L31

Reproduction

See Slack thread: https://jpl.slack.com/archives/C0163E42UBF/p1754545496386969

Logs


System Info

Windows browser client (XML possibly edited in Windows)

Severity

Minor

cartermak avatar Aug 07 '25 17:08 cartermak