aerie icon indicating copy to clipboard operation
aerie copied to clipboard
verified publisher icon NASA-AMMOS

Procedural Scheduling activity auto-deletion

Open JoelCourtney opened this issue 1 year ago • 1 comments

  • Tickets addressed: #1609
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Not ready for review. I'm just using this for the e2e tests.

Verification

Documentation

Future work

JoelCourtney avatar Dec 13 '24 00:12 JoelCourtney

@Mythicaeda I caught a bug and pushed a fairly large commit to fix it. The sim facade checks if the plan has been simulated before so it can use cached results, but it (correctly) doesn't check for ID equality, only activity type/args/time equality. If the IDs are unequal (which is now common behavior with auto-deletion) the sim facade returns sim results with IDs that don't match the input plan. So I made the facade map the returned results to use the new ids from the input plan.

JoelCourtney avatar May 13 '25 23:05 JoelCourtney

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar May 20 '25 17:05 sonarqubecloud[bot]

@Mythicaeda will review this for next release

dandelany avatar May 22 '25 20:05 dandelany