3DTilesRendererJS icon indicating copy to clipboard operation
3DTilesRendererJS copied to clipboard

Render disorder after version 0.3.10

Open Junior2Ran opened this issue 2 years ago • 4 comments

I noticed that on CHANGELOG Fix the application of the tile "up" axis adjustments.

Before this fix, the render output is correct. However, afther this version, the render output turns out to be a mass and disorder. How would this happen?

Junior2Ran avatar Jul 18 '22 09:07 Junior2Ran

@Junior2Ran it's possible there was an issue in the updated implementation. Can you provide images of before / after and example data to reproduce the issue?

The updates were made in #260, and the original issue was #184

gkjohnson avatar Jul 18 '22 15:07 gkjohnson

Actually, I'm not sure that the problem is caused by this axis fix.

However, with version 0.3.9 it seems like image

wiith version 0.3.10 it turns out to be a mass, full of unexpected coordinates disorder, z-fighting, LOD disorder image

You are the professional guy, I assume that you can find a clue to solve the problem. And I'm glad to provid some wild guess

Junior2Ran avatar Jul 19 '22 02:07 Junior2Ran

You are the professional guy, I assume that you can find a clue to solve the problem. And I'm glad to provid some wild guess

Unfortunately I don't have the bandwidth to find and solve everyones issues for them. I'll need your help to track down the PR / commit that broke your dataset and then we can talk about how to address it and where the regression came from - if those are buildings are all instanced from an i3dm file then it is possible that it was broken in #260 but I can't be sure.

gkjohnson avatar Jul 19 '22 03:07 gkjohnson

The buildings are from b3dm files, and the upAxis is z. I've reviewed #260 , it seems likely to be caused by this PR. I will take some time to debug the code and find out the reason later.

Junior2Ran avatar Jul 19 '22 06:07 Junior2Ran

@Junior2Ran - are you able to provide a sample data set? It would be nice to get to the bottom of this

gkjohnson avatar Sep 25 '22 00:09 gkjohnson

@Junior2Ran I'm going to assume that this was actually fixed in #273 and released in v0.3.12. In the future it's helpful to provide test data so the issues can be tested and confirmed.

Thanks!

gkjohnson avatar Sep 26 '22 23:09 gkjohnson