NASA-AMMOS
Add React 19 Support
I'm currently working on a project that uses React 19.1.0, and I'm seeing an npm error when updating from v0.4.9 to 0.4.10 due to the new peerOptional dependency on react@"^18.3.1".
npm ERR! Could not resolve dependency:
npm ERR! peerOptional react@"^18.3.1" from [email protected]
I'm assuming the conflict will be the same for react-dom, three, and @react-three/fiber. Would it be possible to update those peer dependency version ranges to support React 19? Thanks!
Environment:
- Node: 22.16.0
- npm: 11.4.1
- react: 19.1.0
- 3d-tiles-renderer: 0.4.10
- three: 0.176.0
- @react-three/fiber: 9.1.2
Would you like to make a PR that adjusts the peer dependency to support React 19? I'd prefer not to drop support for React 18, though, so lets set the field such that both versions can be supported.
@gkjohnson It took some time to sort this out with my company, but yes now I am able to make a PR to adjust that. I will make sure support is maintained for both React 18 and React 19. I will put up a PR from a different account sometime next week.
@gkjohnson Hello! This is that other account, any reason why I wouldn't be able to push up my branch? I can see the repo is public, but I don't think I have push access.
You have to create a fork of the repository to push your own changes. You cannot directly push changes to or modify someone else's repository without added permissions.