gitlab icon indicating copy to clipboard operation
gitlab copied to clipboard

Add users disable 2FA

Open antons- opened this issue 3 years ago • 3 comments

Adds support for the disable two factor authentication endpoint introduced in GitLab 15.2.

antons- avatar Aug 02 '22 04:08 antons-

Regarding the failed Rubocop test - I wasn't sure on the best way to deal with this. Did we want to increase the line length limit?

antons- avatar Aug 02 '22 04:08 antons-

You could disable the cop, via comment, for that one line. Not sure how @NARKOZ would feel about updating the line length for the whole project.

asedge avatar Aug 03 '22 15:08 asedge

Thanks @asedge for the suggestion. For now I have disabled the cop via comment, and now all the tests are passing.

I should point out that the max limit for the Layout/LineLength cop is 127 characters - whereas my change makes the line 128 characters (1 character over the limit).

@NARKOZ Let me know what you think.

antons- avatar Aug 15 '22 06:08 antons-

Thank you for your contribution! 😄

asedge avatar Oct 17 '22 13:10 asedge