gifs-for-github icon indicating copy to clipboard operation
gifs-for-github copied to clipboard

Stopped working on "Files changed" (review) tab

Open dgeelen-uipath opened this issue 3 years ago • 2 comments

Hi, first of all thanks for a great add on!

I'm not sure when, or if it's just me, but recently the "GIF" button has only been appearing on the "Conversation"-tab editor, and is no longer available on the code-review editor :( It would be really nice if this functionality could be restored :)

dgeelen-uipath avatar Jan 25 '22 12:01 dgeelen-uipath

Thanks for raising this 🙌

I have just merged a fix for the button not appearing when editing a comment in the "Conversation" tab (https://github.com/N1ck/gifs-for-github/pull/41). This should be out in the next release but let me know if it's still a problem.

I have taken a brief look at fixing it within the code-review editor and it's not quite as simple. I will have a go at this when I have some time 💪

N1ck avatar Jan 25 '22 22:01 N1ck

Im still not seeing when I try to add a new comment on a line via the Files Changed tab

timbrownsf avatar Aug 02 '22 00:08 timbrownsf

Still not seeing it 😢

trevor-atlas avatar Nov 28 '22 15:11 trevor-atlas

Sorry that it took so long to get to this. I am releasing a new version now that I hope resolves the issue

N1ck avatar Nov 29 '22 01:11 N1ck