Nehal Sharma

Results 115 comments of Nehal Sharma

@timabbott Made the change, this should be good to merge now :)

@timabbott Thanks for catching that error! The code did intend to handle the case where a todo list has no title, by defaulting it to an empty string when activating...

The recent migration of `submessage.ts` and the lack of types defined for the new `extra_data` for the todo widget there is why this does not work. I'm figuring out how...

@LaPulgaaa Could you please review the type / Zod related code commit wise (mainly just in `submessage.ts` amd `widgetize.ts`)?

> @N-Shar-ma, do you think it is ready to be tested now? Yes it is, thanks @sov-j !

@sov-j Thank you so much, that was helpful! ~I'll change "Add poll" to "Send poll" in both locations.~ I just remembered I'd changed it since otherwise the modal (and compose...

> One more thing I noticed while playing with the PR is that if we remove the last row and update rows except the last row, it won't add a...

@alya This might be ready for you to have a look!

@alya Have implemented the 1st and 3rd points that you raised. Here are screenshots: ![image](https://user-images.githubusercontent.com/68962290/181913393-878442a6-978d-4d89-9595-bcab6e8b1537.png) (apart from the updated text in the modal, notice the text in the compose box)...