Results 265 comments of NRK

@tansy You're using `Makefile_Linux` which according to the git log has not been updated in 6 years. I'm using `gccLinux64.mak` which doesn't enable `-fwriteable-strings` nor `-ansi` (which is causing `inline`...

> add a way to package mpv scripts/shaders/etc. and make them updatable, to automatically manage these scripts I have a very rough proof-of-concept for managing plugins via `git`. Currently tested...

> I don't think such preference is necessary. It's not a preference. It's the de facto standard.

> FFmpeg and gcc for example use single dash for long options, which doesn't conform to the "standard". I wasn't talking about long options, which don't have any standard (neither...

> [...] probably you shouldn't spend your time for an open source project This is not your place to state what others should or should not do in their own...

> When exiting the player, there is no need to clear all of this, let the kernel reclaim the memory after the program exits. *Ideally* this should be done everywhere,...

I initially suggested this [in here](https://github.com/mpv-player/mpv/issues/12294#issuecomment-1698294974) but forgot about it: but instead of LSan specific suppression, you can just avoid setting `quit_fast` in debug builds. This is arguably better since...

Mostly bikeshedding but I feel quite strongly about the following comment, so I'll leave a response: > buy more RAM This might be appropriate if the software actually needs/uses additional...

> This is arguably better since it will always exercise the cleanup code under debug builds ~~Looks like this is definitely the better way since it already found cases where...

I think instead of a single bool, you need 2. One that tells you whether quit fast is enabled or not, and other that gets set when the quit command...