Mark

Results 600 comments of Mark

Thanks for the PR! Could you include some tests for the new functionality?

> For example, if we wanted to execute only the above test, we would run the command unittest test/sql/projection/test_simple_projection.test. If we wanted to run all tests in a specific directory,...

Should be fixed by https://github.com/duckdb/duckdb/pull/4773

Maybe call it `approx_rows_per_batch` for clarity then?

> Primarily I think we should store the tag itself into the union primary vector while the members are stored in children instead of implicitly have it be determined by...

That is exactly what this flag is for, no?

In general I would say fixing warnings in third party code, especially code as well-tested as ICU, is very low priority. Feel free to push this fix if it is...