MystenLabs
wallet-ext: allow selecting the accounts to connect to dapp
- adds WalletListSelect component that allows selecting between the accounts of the wallet and creating new ones
- when multiaccounts is enabled while connecting to a dapp user is able to choose which accounts to connect
When multiaccount is disabled
When multiaccount is enabled and user has more than one account
https://user-images.githubusercontent.com/10210143/219980417-79a944d4-b409-4046-832a-09d8b98b2c40.mov
NOTE: To check the accounts that are connected
- switch between accounts and check the dapp status popup
- or run
chrome.storage.local.get('permissions').then(({permissions: p}) => console.log(p['http://localhost:3000'].accounts))
in the console of the extension.
Closes APPS-283
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| explorer | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 24, 2023 at 1:24AM (UTC) |
| explorer-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 24, 2023 at 1:24AM (UTC) |
| frenemies | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 24, 2023 at 1:24AM (UTC) |
| wallet-adapter | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 24, 2023 at 1:24AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looking good in general. A few UI details that need to be aligned with Figma,
Rounder corner spec
Spacing of content inside both cards
looks like a border is getting used for the rectangle. It should be a line that separates the bottom row from the content above instead. Please double check spacing,
No need to show the toast when a new account is created. May be capture this in the new ticket you are going to create,
@mystie711
About 'Rounder corner spec, this should be addressed by this ticket https://mysten.atlassian.net/browse/APPS-519. I will need to reuse some components from other PRs once merged will update this. (I just left it as it was for now)
About spacing/border ~will check~ Those have been fixed in another PR that will be merged together with this one so it's already addressed
For creating New Account added this ticket
Is there an updated video of this?
this is how it would be after merging this one
https://user-images.githubusercontent.com/10210143/220960280-b832d243-4bf7-40e5-bcae-e292d210fd53.mov