sui icon indicating copy to clipboard operation
sui copied to clipboard

[move] Bump Move version

Open amnn opened this issue 2 years ago • 5 comments

Includes fix to module-handle order stability issue in move-language/move#890

Test Plan

$ cargo nextest run

amnn avatar Feb 13 '23 22:02 amnn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
explorer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 8:19PM (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 8:19PM (UTC)
frenemies ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 8:19PM (UTC)
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 8:19PM (UTC)

vercel[bot] avatar Feb 13 '23 22:02 vercel[bot]

@tnowacki, there's some strangeness with module orders in the build output of sui-framework, and I can't figure out if it's because of a stale dependency on the old move-compiler during build or something else -- so I was checking by submitting to CI first.

I can't seem to shake it locally though, even after fixing workspace-hack and deleting target.

amnn avatar Feb 13 '23 23:02 amnn

Yep, sadly persistent -- needs further investigation -- the order of modules is very strange, it interleaves sui::... and std::... modules, which does not really make sense.

amnn avatar Feb 13 '23 23:02 amnn

For example:

// Move bytecode v6
module 2.address {
use 0000000000000000000000000000000000000001::ascii;
use 0000000000000000000000000000000000000001::string;
use 0000000000000000000000000000000000000002::hex;
use 0000000000000000000000000000000000000001::bcs;

(From my local network)

amnn avatar Feb 13 '23 23:02 amnn

For example:

// Move bytecode v6
module 2.address {
use 0000000000000000000000000000000000000001::ascii;
use 0000000000000000000000000000000000000001::string;
use 0000000000000000000000000000000000000002::hex;
use 0000000000000000000000000000000000000001::bcs;

(From my local network)

da eff

tnowacki avatar Feb 13 '23 23:02 tnowacki