sui icon indicating copy to clipboard operation
sui copied to clipboard

Do not use f64 for STORAGE_REBATE_RATE

Open dariorussi opened this issue 2 years ago • 2 comments

as in https://github.com/MystenLabs/sui/pull/8102 the idea is to remove the f64 to be on the safer side

dariorussi avatar Feb 04 '23 23:02 dariorussi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Feb 14, 2023 at 4:10PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Feb 14, 2023 at 4:10PM (UTC)
frenemies ⬜️ Ignored (Inspect) Feb 14, 2023 at 4:10PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Feb 14, 2023 at 4:10PM (UTC)

vercel[bot] avatar Feb 04 '23 23:02 vercel[bot]

@emmazzz take a look. I tried removing the rounding to use truncation but I got a bunch of errors in tests and it was a bit too much for me to change. It did not seem to be worth the effort. I splashed a comment there that should be enough to clarify. Please take a look

dariorussi avatar Feb 14 '23 16:02 dariorussi