sui icon indicating copy to clipboard operation
sui copied to clipboard

Benchmarks with dummy signature scheme

Open jonas-lj opened this issue 2 years ago • 1 comments

This is not supposed to be merged. The PR is created to test the code in CI before it's deployed to testnet.

jonas-lj avatar Jan 26 '23 20:01 jonas-lj

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Mar 12, 2023 at 5:07PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Mar 12, 2023 at 5:07PM (UTC)
frenemies ⬜️ Ignored (Inspect) Mar 12, 2023 at 5:07PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Mar 12, 2023 at 5:07PM (UTC)

vercel[bot] avatar Jan 26 '23 20:01 vercel[bot]

Ooc, is there a better pattern (ie load the key type from some config) to be able to switch key types without changing the code each time?

yeah it seems a bit more complex as we pin validator sig Vs being abstracted, maybe it's a feature as we should be careful with that and when we agree on the scheme we won't change it. All good, thanks for this PR, very useful for benchmarking

We could add the extra functions under a feature flag or something like that, but it would add quite a bit of code that is redundant when not running with unsecure signatures, so I think having this PR and keeping it up to date every few days is probably just as easy.

jonas-lj avatar Mar 03 '23 20:03 jonas-lj