sui icon indicating copy to clipboard operation
sui copied to clipboard

Consider making gas_price an optional field

Open lxfind opened this issue 2 years ago • 3 comments

And if it's None, just default to reference gas price.

lxfind avatar Jan 26 '23 19:01 lxfind

What is gas_price and what is the context? I'm assuming that every tx uses up gas_units, and that on devnet we've seen a fixed 1 gas_unit = 1 nanoSUI price, whereas on testnet there is now a 1 gas_unit = nanoSUI price relationship that changes every epoch.

For the Sui CLI, I find it annoying that I always need to specify --gas-budget when in reality I don't care and would prefer if it would default to some large-enough-most-of-the-time value.

PaulFidika avatar Jan 26 '23 20:01 PaulFidika

It's this field: https://github.com/MystenLabs/sui/blob/main/crates/sui-types/src/messages.rs#L632

lxfind avatar Jan 26 '23 21:01 lxfind

we are considering leaving the gas_price as is (non Optional). We have not received much feedback about making it optional, it is something clients (wallet and apps) can hide, and it makes slightly easier to run history transaction. Not clear there is much benefit.

dariorussi avatar Feb 09 '23 19:02 dariorussi