sui icon indicating copy to clipboard operation
sui copied to clipboard

Add support for separately configured address for own workers

Open aschran opened this issue 3 years ago • 2 comments

aschran avatar Nov 22 '22 16:11 aschran

  1. Sui contacting its own worker makes a lot of sense to me (prior art: MystenLabs/narwhal#715), but could you say more about the use case in which Narwhal itself would need access to this information?

This is for Narwhal primary to contact its own workers, just using a different address than a remote primary would use.

  1. Usual naming for addresses to the same logical machine centers around the adjectives "internal" rather than "own". internal_worker_address?

The name "own" vs "others" is used in the narwhal codebase already (eg "own" vs "others" batch message types, and in the Committee struct "own" vs "others" for workers and primaries). So I chose this name to stay consistent.

aschran avatar Nov 22 '22 21:11 aschran

The name "own" vs "others" is used in the narwhal codebase already (eg "own" vs "others" batch message types, and in the Committee struct "own" vs "others" for workers and primaries). So I chose this name to stay consistent.

@aschran the worker_address that sits right next to the own_worker_address which you're introducing is also the primary's own worker's address, albeit its public one. I think we're reaching for a distinct qualifier here.

huitseeker avatar Nov 23 '22 14:11 huitseeker