sui icon indicating copy to clipboard operation
sui copied to clipboard

Handle known effects in TransactionManager

Open mystenmark opened this issue 3 years ago • 2 comments

mystenmark avatar Nov 17 '22 00:11 mystenmark

@mwtian thanks for the review - this whole thing is getting very awkward. in addition to the races you pointed out, we also need to try to co-exist with the new effects store added by @bmwill for data sync. I think any attempt to combine the pending certs and effects into the same table is going to run into races unless we have optimistic transactions (which we don't) or protect the table with a lock.

If you want to take a crack at this feel free - otherwise I will tackle it next week after the holiday.

mystenmark avatar Nov 23 '22 16:11 mystenmark

@mwtian thanks for the review - this whole thing is getting very awkward. in addition to the races you pointed out, we also need to try to co-exist with the new effects store added by @bmwill for data sync. I think any attempt to combine the pending certs and effects into the same table is going to run into races unless we have optimistic transactions (which we don't) or protect the table with a lock.

If you want to take a crack at this feel free - otherwise I will tackle it next week after the holiday.

Good to know. I will take a deeper look at this after holidays too. Will set up a time to chat off thread.

mwtian avatar Nov 23 '22 19:11 mwtian