[core] Refactor Transaction to use MessageEnvelope

Open lxfind opened this issue 3 years ago • 2 comments

Currently Transaction type is defined using its own Envelope (i.e. TransactionEnvelope) This PR changes it to use the MessageEnvelope that all authenticated data structures can use. The primary change is in message_envelope.rs and messages.rs, where we consolidate the definition of Transaction.

Nov 07 '22 19:11 lxfind

overall lgtm!

to confirm, this is not adding epoch id to what authority is signing on correct? im working on adding this, will rebase on this PR

Nov 08 '22 01:11 joyqvq

to confirm, this is not adding epoch id to what authority is signing on correct?

Correct, this PR doesn't add signing to epoch id.

Nov 08 '22 02:11 lxfind