sui icon indicating copy to clipboard operation
sui copied to clipboard

Corrects a directory name. Adds parent directories

Open 3rror404 opened this issue 2 years ago • 4 comments

3rror404 avatar Oct 25 '22 14:10 3rror404

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3321657872#artifacts

github-actions[bot] avatar Oct 28 '22 18:10 github-actions[bot]

I don't agree with this change. The linked text shows the name of the component, it doesn't need to also include part of the path

randall-Mysten avatar Oct 28 '22 18:10 randall-Mysten

@randall-Mysten Fair point. In which case, do you think it's useful to update the sentence introducing the enumeration, i.e.:

You can start exploring Sui's source code by looking into the following primary directories: to clarify how "primary directories" should be interpreted by the reader?

huitseeker avatar Nov 04 '22 20:11 huitseeker

Is the intention to call out the primary directories, or list the key components and link to the folder that contains them? As a user, am I looking for a primary folder, or source code for a binary or app? What if it listed these things, linked to the folder as it does now, and displayed the path inline so people that want to navigate through the repo can easily find them?

randall-Mysten avatar Nov 04 '22 21:11 randall-Mysten

Please reopen if this is still a relevant issue. Closing stale PRs

randall-Mysten avatar Feb 14 '23 17:02 randall-Mysten