sui icon indicating copy to clipboard operation
sui copied to clipboard

use flat vm fee

Open oxade opened this issue 2 years ago • 1 comments

This adds the flat fee for VM gas logic

The fee itself is subject to change Finding the right number took a few iterations and will probably take a lot more once folks start using the new feature

oxade avatar Sep 13 '22 20:09 oxade

simtest failure is unrelated

oxade avatar Sep 13 '22 21:09 oxade

@tnowacki I spoke to @srinath-mysten
We decided to combine gas estimation with this PR to minimize friction for devs who might find their gas budgets are no longer sufficient. Hence feel free to approve, but not merge this PR.

oxade avatar Sep 14 '22 20:09 oxade

@tnowacki I spoke to @srinath-mysten We decided to combine gas estimation with this PR to minimize friction for devs who might find their gas budgets are no longer sufficient. Hence feel free to approve, but not merge this PR.

Moving PR to draft while we add estimation logic

oxade avatar Sep 14 '22 20:09 oxade

Another way to reduce dev friction is to ship estimation logic first by using the flat fee here.

lxfind avatar Sep 14 '22 20:09 lxfind

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3232781121#artifacts

github-actions[bot] avatar Oct 09 '22 22:10 github-actions[bot]

Tests are failing due to unrelated Narwhal issues. Waiting for fix.

oxade avatar Oct 10 '22 17:10 oxade

Another way to reduce dev friction is to ship estimation logic first by using the flat fee here.

This is done

oxade avatar Oct 10 '22 20:10 oxade

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

github-actions[bot] avatar Oct 12 '22 07:10 github-actions[bot]