sui icon indicating copy to clipboard operation
sui copied to clipboard

add script that runs prover on sui framework

Open emmazzz opened this issue 3 years ago • 2 comments

This draft PR contains a script that runs sui move prove on sui framework Move code. It would be great if we can run this in CI as a sanity check that the changes in a PR don't break sui move prove.

This script is adapted from the script in Move repo that runs diem framework in CI: https://github.com/move-language/move/blob/main/language/documentation/examples/diem-framework/prove_all.sh

In order for sui move prove to work, we need to install a few dependencies including dotnet, Boogie, Z3, CVC5. We can probably do something similar to what the move repo does in github actions: https://github.com/move-language/move/blob/main/.github/actions/build-setup/action.yml#L45-L60

emmazzz avatar Jul 29 '22 20:07 emmazzz

@emmazzz Do you think we should include this as part of the cluster tests we are planning on running in continuous environment? Example cargo run --bin sui-cluster-test -- dev-net

ebmifa avatar Jul 29 '22 22:07 ebmifa

@emmazzz Do you think we should include this as part of the cluster tests we are planning on running in continuous environment? Example cargo run --bin sui-cluster-test -- dev-net

The test in this PR is more like unit tests for the Move contracts. I don't think it's necessary to test this in a cluster setting, unless I misunderstood the idea of cluster test.

emmazzz avatar Jul 30 '22 00:07 emmazzz

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 28 '22 02:09 github-actions[bot]