sui icon indicating copy to clipboard operation
sui copied to clipboard

Buffer mysticeti fastpath execution results

Open lxfind opened this issue 7 months ago • 1 comments

Description

Temporarily put fastpath execution results in a separate in the writeback cache. These results will be flushed to the normal dirty cache if it ever gets executed from non fastpath.

Test plan

Added unittests.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] gRPC:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:

lxfind avatar May 29 '25 03:05 lxfind

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2025 9:18pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2025 9:18pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2025 9:18pm

vercel[bot] avatar May 29 '25 03:05 vercel[bot]

Just to make sure, currently if a txn comes out of fastpath first and executes, it will not execute again when received via consensus commit or checkpoint sync. Is this still the case?

Correct. We will flush it from the temporary buffer to the dirty cache, and then see that it has already been executed and won't execute it again.

Also, consensus block handler and consensus commit handler can race against each other because they are separate tasks listening to separate channels. A txn can execute via commit first, then via fastpath. This is handled correctly, right?

Correct. If it has been executed, it certainly won't execute again.

lxfind avatar Jun 04 '25 23:06 lxfind