sui icon indicating copy to clipboard operation
sui copied to clipboard

WIP: Embed Jemalloc in Sui Node

Open RyanSquared opened this issue 7 months ago • 1 comments

Description

Use the tikv-jemallocator crate to define a #[global_allocator], and enable the jemalloc feature of librocksdb-sys to leverage builtin jemalloc.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [X] Nodes (Validators and Full nodes): Embed Jemalloc instead of using LD_PRELOAD; no change required.
  • [ ] gRPC:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:

This should not be merged as-is as it may affect the performance of nodes even outside of sui-node-deterministic. While there should be no noticeable difference, I haven't been able to do a proper comparison by myself. I am requesting help from @jnaulty to get some performance testing on this to see how it compares versus the static glibc malloc.

RyanSquared avatar May 23 '25 06:05 RyanSquared

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 6:14am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 6:14am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 6:14am

vercel[bot] avatar May 23 '25 06:05 vercel[bot]

closing due to: https://github.com/MystenLabs/sui/pull/22517

jnaulty avatar Jun 26 '25 19:06 jnaulty