sui icon indicating copy to clipboard operation
sui copied to clipboard

fix: replace deprecated #[clap(...)] with #[command(...)] and #[arg(...)]

Open Himess opened this issue 7 months ago • 9 comments

Description

Erros : cargo check --features clap/deprecated Pasted Graphic 6

This PR updates all deprecated #[clap(...)] and #[arg(name = ...)] usages throughout the codebase to align with clap v4 attribute style.

Changes include:

  • Replaced #[clap(...)] with #[command(...)] and #[arg(...)]
  • Replaced deprecated name = with value_name = where appropriate

Test plan

Solve : cargo check --features clap/deprecated Pasted Graphic 8

(There are still a few remaining warnings. I will create another PR to address them.) image

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] gRPC:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:

Himess avatar May 10 '25 18:05 Himess

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 8:37pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 19, 2025 8:37pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 19, 2025 8:37pm

vercel[bot] avatar May 10 '25 18:05 vercel[bot]

@amnn Thanks for review . I will update or i can create other PR to solve it.

Himess avatar May 14 '25 21:05 Himess

Best to update this PR -- we don't want to land this one with that change (it will mess up doc generation).

amnn avatar May 14 '25 21:05 amnn

Got it, agreed. I’ll update it as soon as possible and tag you.

Himess avatar May 14 '25 21:05 Himess

@amnn Done. Could you check again ?

Himess avatar May 15 '25 09:05 Himess

@Himess it looks like there are some cases where arg was used instead of command etc. Can you take a look at the CI output and fix the issues? I will then reschedule the workflows.

amnn avatar May 15 '25 20:05 amnn

@amnn When i crate PR , i didn 't get any errors. I think that happend for conflicts or smthmg. I will check again and i will update thanks !

Himess avatar May 15 '25 21:05 Himess

@amnn Ready to review sir.

Himess avatar May 16 '25 17:05 Himess

@amnn I think it must be work right now :) sory for delay. Could you run CI again ?

Himess avatar May 19 '25 20:05 Himess

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 20 '25 02:07 github-actions[bot]