sui icon indicating copy to clipboard operation
sui copied to clipboard

Published 20 hours ago • verified publisher icon MystenLabs

update print for create wallet

Open Romainua opened this issue 2 years ago • 4 comments

Update first print! for creating wallet, I think it will be better for visual perception

Romainua avatar May 20 '22 21:05 Romainua

Hi Romainua Roman,

Thanks again for all of these fixes. Please note, we just merged many changes from our main (upstream) branch to devnet which addresses some but not all of these changes.

Can you rebase and include only the unique fixes? That should address the merge conflicts.

Also, please consider working in main right along with us. Let me know if you have any questions.

Does the change in the devnet come from the main? So I'll work there

Romainua avatar May 25 '22 21:05 Romainua

Hi Romainua Roman, Thanks again for all of these fixes. Please note, we just merged many changes from our main (upstream) branch to devnet which addresses some but not all of these changes. Can you rebase and include only the unique fixes? That should address the merge conflicts. Also, please consider working in main right along with us. Let me know if you have any questions.

Does the change in the devnet come from the main? So I'll work there

Yes, please! I'm sorry for the confusion. We cut devnet from main but are just settling on doing the same for docs.sui.io, which will allows the docs and code to be in sync but the stable devnet version we recommend to be slightly behind.

We are working to formalize this and appreciate your feedback too! Please let us know here or at: [email protected]

Thanks again and sorry for the confusion.

Clay-Mysten avatar May 25 '22 21:05 Clay-Mysten

Everything is very cool, sometimes I find some outdated information in the doc, but I think this is not a problem. Sorry, I didn't quite understand what to write to the email 😄

Romainua avatar May 25 '22 22:05 Romainua

Everything is very cool, sometimes I find some outdated information in the doc, but I think this is not a problem. Sorry, I didn't quite understand what to write to the email 😄

We appreciate your help immensely. I just want to make sure you are editing the latest contents so as to not duplicate work and get the most out of your help. Please work in the main branch, and we will gladly review/approve changes.

Thank you so much!

Clay-Mysten avatar May 25 '22 22:05 Clay-Mysten

I am closing this request as it is from several months ago. Please reactivate if there are still issues, or submit a separate PR starting with the main branch of the repo.

randall-Mysten avatar Sep 22 '22 18:09 randall-Mysten