sui icon indicating copy to clipboard operation
sui copied to clipboard

[file progress store] make FileProgressStore not fail on read

Open zihehuang opened this issue 1 year ago • 2 comments

Description

File progress store fails on read if the provided progress file path does not exist. This PR allows FileProgressStore to load without the progress file present. When save is called, the progress is saved to file as usual.

Test plan

Updated existing test


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [x] Indexer: A user no longer need to pre-create the progress file when using the FileProgressStore in the custom indexer
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:
  • [ ] REST API:

zihehuang avatar Aug 15 '24 15:08 zihehuang

@zihehuang is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 15 '24 15:08 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:54pm

vercel[bot] avatar Aug 15 '24 15:08 vercel[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 16 '24 02:10 github-actions[bot]