Create a separate congestion control consensus commit limit for Mysti…

[halfprice]

…ceti

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?

---

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

• [ ] Protocol:
• [ ] Nodes (Validators and Full nodes):
• [ ] Indexer:
• [ ] JSON-RPC:
• [ ] GraphQL:
• [ ] CLI:
• [ ] Rust SDK:

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sui-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2024 6:51pm

[vercel[bot]]

@halfprice is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions[bot]]

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

[halfprice]

If this feature will be enabled in testnet 1.30, I think the Narwhal config will probably never be used in testnet or mainnet.

Also Mysticeti commit rate can be affected significantly by network conditions. How difficult it will be to make the cost per object limit apply to a fixed time window (e.g. 1s) instead of per consensus commit? The ratio of the cost limits do correspond to the commit rates ratio though. So keeping this mechanism for the short term should be ok.

Yes, we do have a plan to make the rate per second, but that requires a larger change with a new DB column to store last consensus timestamp. Thanks for confirming that this is ok for short term.