sui icon indicating copy to clipboard operation
sui copied to clipboard

Adds multi-commit checkpoint batching in Sui.

Open aschran opened this issue 1 year ago • 1 comments

Description

Adds version_specific_data to CheckpointSummary to keep track of which RandomnessRounds are present in a checkpoint.

Batching is configurable by a minimum interval based on the commit timestamp.

Test plan

Unit/integration tests, manual testing in synthetic environment.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • [ ] Protocol:
  • [ ] Nodes (Validators and Full nodes):
  • [ ] Indexer:
  • [ ] JSON-RPC:
  • [ ] GraphQL:
  • [ ] CLI:
  • [ ] Rust SDK:

aschran avatar May 28 '24 18:05 aschran

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:36am
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:36am
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:36am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:36am

vercel[bot] avatar May 28 '24 18:05 vercel[bot]

Semgrep found 1 ssc-efa14576-9601-4ae6-939c-3da58aa25013 finding:

  • examples/trading/frontend/pnpm-lock.yaml

Risk: Affected versions of vite are vulnerable to Improper Handling Of Case Sensitivity / Exposure Of Sensitive Information To An Unauthorized Actor / Improper Access Control. The vulnerability arises when the Vite development server's option, server.fs.deny, can be circumvented on case-insensitive file systems through the utilization of case-augmented versions of filenames, as the matcher derived from config.server.fs.deny fails to prevent access to sensitive files when raw filesystem paths are requested with augmented casing.

Manual Review Advice: A vulnerability from this advisory is reachable if you host vite's development server on Windows, and you rely on server.fs.deny to deny access to certain files

Fix: Upgrade this library to at least version 4.5.2 at sui/examples/trading/frontend/pnpm-lock.yaml:4700.

Reference(s): https://github.com/advisories/GHSA-c24v-8rfc-w8vw, CVE-2023-34092, CVE-2024-23331

Ignore this finding from ssc-efa14576-9601-4ae6-939c-3da58aa25013.