sui icon indicating copy to clipboard operation
sui copied to clipboard

Several caching improvements:

Open mystenmark opened this issue 1 year ago • 1 comments

  • Populate the cache with the latest object version when possible.
  • Add negative caching for getting object by id.
  • Use latest version cache for satisfying dynamic field reads

mystenmark avatar May 24 '24 23:05 mystenmark

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 10:19pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 10:19pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 10:19pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 10:19pm

vercel[bot] avatar May 24 '24 23:05 vercel[bot]

LGTM! Thanks for adding all the detailed comments!

I wonder if it also worth creating some kind of cache invariant checker that runs periodically in simtest to catch issues. Some invariants may be that it could compare objects in dirty/cache/db and in object_by_id_cache, to see if they actually match.

adding a debug check

mystenmark avatar May 30 '24 20:05 mystenmark

LGTM! Thanks for adding all the detailed comments! I wonder if it also worth creating some kind of cache invariant checker that runs periodically in simtest to catch issues. Some invariants may be that it could compare objects in dirty/cache/db and in object_by_id_cache, to see if they actually match.

adding a debug check

LGTM!

halfprice avatar May 30 '24 22:05 halfprice